Skip to content

Feat/1152 activity loader#1176

Closed
utkarshgupta2804 wants to merge 2 commits intoasyncapi:masterfrom
utkarshgupta2804:feat/1152-activity-loader
Closed

Feat/1152 activity loader#1176
utkarshgupta2804 wants to merge 2 commits intoasyncapi:masterfrom
utkarshgupta2804:feat/1152-activity-loader

Conversation

@utkarshgupta2804
Copy link

Summary of Changes

  1. Added a new loader component for improved user experience during content loading.
  2. Created a loader folder inside components.
  3. Implemented skeletonComponents.tsx, PlaygroundSkeleton.tsx, and index.ts for reusable skeleton UI.
  4. Updated page.tsx to integrate the new loader seamlessly.

Testing

  1. Verified loader functionality across different network conditions.
  2. Confirmed consistent rendering and smooth user experience.

Resolves #1152

Preview
Demonstration of the loader in action:

Screen.Recording.2025-09-19.032453.mp4

- Created loader folder inside components
- Added skeletonComponents, PlaygroundSkeleton, and index.ts
- Updated page.tsx to integrate the new loader
- Created loader folder inside components
- Added skeletonComponents, PlaygroundSkeleton, and index.ts
- Updated page.tsx to integrate the new loader
@asyncapi-bot
Copy link
Contributor

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 No release type found in pull request title "Feat/1152 activity loader". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @utkarshgupta2804 👋🏽

Thanks for taking the time to work on this! A couple of quick notes to help for future contributions:

Before opening a PR for an issue, please indicate your interest in the issue so we can confirm it’s good to pick up.

In this case, the activity loader isn’t needed, the delay was coming from the playground itself, and since the playground isn’t actually used by end users, modifying it won’t have an impact.

I’ll go ahead and close this PR, but really appreciate the effort you put in. Please feel free to check out other open issues, we’d love to see more contributions from you.

@utkarshgupta2804 utkarshgupta2804 deleted the feat/1152-activity-loader branch September 20, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Activity Loader on Initial Page Load

3 participants